[ https://issues.apache.org/jira/browse/NIFI-4374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160587#comment-16160587
]
ASF GitHub Bot commented on NIFI-4374:
--------------------------------------
GitHub user glisignoli opened a pull request:
https://github.com/apache/nifi/pull/2141
NIFI-4374 Added buffer size to FTP connections
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying
to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically
master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check
clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file
under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file
found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic
access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/glisignoli/nifi master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2141.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2141
----
commit 12476bf01fe9e16e587128b7739ac1d43eaaf9b1
Author: Gino Lisignoli <glisignoli@gmail.com>
Date: 2017-09-10T22:49:47Z
Added buffer size to FTP connections
----
> Add buffer size support to ftp processors
> -----------------------------------------
>
> Key: NIFI-4374
> URL: https://issues.apache.org/jira/browse/NIFI-4374
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.3.0
> Reporter: Gino Lisignoli
> Priority: Minor
> Labels: newbie
> Fix For: 1.4.0
>
>
> The NIFI xxxFTP Processors are all missing 'setBufferSize' which causes them to use a
very low default value which isn't inefficient.
> Setting a default value of 16KB and allowing users to control this setting should be
implemented.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
|