nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-4341) Display provenance repository storage usage in UI
Date Fri, 08 Sep 2017 19:56:00 GMT

    [ https://issues.apache.org/jira/browse/NIFI-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159194#comment-16159194
] 

ASF GitHub Bot commented on NIFI-4341:
--------------------------------------

Github user mcgilman commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2119#discussion_r137876726
  
    --- Diff: nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java
---
    @@ -521,6 +522,23 @@ public RepositoryConfiguration getConfiguration() {
             return configuration;
         }
     
    +    @Override
    +    public Set<String> getContainerNames() {
    +        return new HashSet<>(configuration.getStorageDirectories().keySet());
    +    }
    +
    +    @Override
    +    public long getContainerCapacity(final String containerName) throws IOException {
    +        final Path path = configuration.getStorageDirectories().get(containerName).toPath();
    --- End diff --
    
    `FileUtils.getContainerCapacity` verifies the containerName is non null. However, if the
specified container is unknown to this repository it will fail here prior to invoking the
`FileUtils`. This issue exists in a number of places in this PR.


> Display provenance repository storage usage in UI
> -------------------------------------------------
>
>                 Key: NIFI-4341
>                 URL: https://issues.apache.org/jira/browse/NIFI-4341
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core UI
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>         Attachments: clusterView.png, systemDiagView.png
>
>
> Just like we have storage usage information for flow file repository and content repository,
it'd be interesting to display the same information for provenance repository in system diagnostic
view and cluster view.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message