nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-4341) Display provenance repository storage usage in UI
Date Fri, 08 Sep 2017 19:56:00 GMT

    [ https://issues.apache.org/jira/browse/NIFI-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159193#comment-16159193
] 

ASF GitHub Bot commented on NIFI-4341:
--------------------------------------

Github user mcgilman commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2119#discussion_r137875951
  
    --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/FileSystemRepository.java
---
    @@ -404,24 +404,13 @@ public FileVisitResult visitFile(final Path file, final BasicFileAttributes
attr
         @Override
         public long getContainerCapacity(final String containerName) throws IOException {
             final Path path = containers.get(containerName);
    -        if (path == null) {
    --- End diff --
    
    This null check ensure's this repository has the specified container. This check was moved
to the utility method in `FileUtils`. I'm not sure there is a condition where the containerName
is unrecognized but this is general defensive programming. No issue here, just referencing
it for other comments.


> Display provenance repository storage usage in UI
> -------------------------------------------------
>
>                 Key: NIFI-4341
>                 URL: https://issues.apache.org/jira/browse/NIFI-4341
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core UI
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>         Attachments: clusterView.png, systemDiagView.png
>
>
> Just like we have storage usage information for flow file repository and content repository,
it'd be interesting to display the same information for provenance repository in system diagnostic
view and cluster view.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message