nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-4335) Update Listen* components to refer to RestrictedSSLContextService
Date Wed, 06 Sep 2017 23:14:00 GMT

    [ https://issues.apache.org/jira/browse/NIFI-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156178#comment-16156178
] 

ASF GitHub Bot commented on NIFI-4335:
--------------------------------------

Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2131#discussion_r137413455
  
    --- Diff: nifi-nar-bundles/nifi-grpc-bundle/nifi-grpc-processors/src/main/java/org/apache/nifi/processors/grpc/ListenGRPC.java
---
    @@ -82,25 +83,29 @@
         // properties
         public static final PropertyDescriptor PROP_SERVICE_PORT = new PropertyDescriptor.Builder()
                 .name("Local gRPC service port")
    +            .displayName("Local gRPC Service Port")
                 .description("The local port that the gRPC service will listen on.")
                 .required(true)
                 .addValidator(StandardValidators.PORT_VALIDATOR)
                 .build();
         public static final PropertyDescriptor PROP_USE_SECURE = new PropertyDescriptor.Builder()
    -            .name("Use SSL/TLS")
    -            .description("Whether or not to use SSL/TLS to send the contents of the gRPC
messages.")
    +            .name("Use TLS")
    --- End diff --
    
    The `name` value needs to stay the same so that templates and flows which referenced the
previous version will continue to work. If this value changes, existing templates and flows
will not be read correctly and these values will be lost. This is why `displayName` was introduced.



> Update Listen* components to refer to RestrictedSSLContextService
> -----------------------------------------------------------------
>
>                 Key: NIFI-4335
>                 URL: https://issues.apache.org/jira/browse/NIFI-4335
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework, Extensions
>    Affects Versions: 1.3.0
>            Reporter: Andy LoPresto
>            Assignee: Michael Hogue
>              Labels: jetty, security, tls
>
> [~m-hogue] added a {{RestrictedSSLContextService}} in NIFI-2528 due to discussions regarding
the baseline TLS protocol versions that are supported as of NiFi 1.2.0. The {{ListenHTTP}}
processor was updated to require this new interface, but other {{Listen*}} processors and
services need to be updated as well. 
> From discussion on PR 1986: 
> {quote}
> Also, as @joewitt noted earlier, we should change the available interface for other "listener"
processors. Here's a preliminary list I put together, but I would like confirmation from another
member:
> * `HandleHTTPRequest`
> * `ListenBeats`
> * `DistributedCacheServer`/`DistributedSetCacheServer`/`DistributedMapCacheServer`
> * `ListenSMTP`
> * `ListenGRPC`
> * `ListenLumberjack` (*Deprecated*)
> * `ListenRELP`
> * `ListenSyslog`
> * `ListenTCP`/`ListenTCPRecord`
> Also:
> * `AbstractSiteToSiteReportingTask`
> * `org.apache.nifi.processors.slack.TestServer`
> * `WebSocketService`/`JettyWebSocketService`
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message