nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (NIFI-4335) Update Listen* components to refer to RestrictedSSLContextService
Date Wed, 06 Sep 2017 18:34:00 GMT


ASF GitHub Bot commented on NIFI-4335:

GitHub user m-hogue opened a pull request:

    NIFI-4335: Changed SSL Context Service implementations to RestrictedS…

    …SLContextService for all Listen* processors
    Thank you for submitting a contribution to Apache NiFi.
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying
to resolve? Pay particular attention to the hyphen "-" character.
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically
    - [ ] Is your initial contribution a single, squashed commit?
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check
clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](

    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file
under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file
found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic
access) for each of the new properties?
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.

You can merge this pull request into a Git repository by running:

    $ git pull NIFI-4335

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2131
commit f89fb4fcd37f474150d426c3446e16fe532dd9e7
Author: m-hogue <>
Date:   2017-09-06T18:33:11Z

    NIFI-4335: Changed SSL Context Service implementations to RestrictedSSLContextService
for all Listen* processors


> Update Listen* components to refer to RestrictedSSLContextService
> -----------------------------------------------------------------
>                 Key: NIFI-4335
>                 URL:
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework, Extensions
>    Affects Versions: 1.3.0
>            Reporter: Andy LoPresto
>            Assignee: Michael Hogue
>              Labels: jetty, security, tls
> [~m-hogue] added a {{RestrictedSSLContextService}} in NIFI-2528 due to discussions regarding
the baseline TLS protocol versions that are supported as of NiFi 1.2.0. The {{ListenHTTP}}
processor was updated to require this new interface, but other {{Listen*}} processors and
services need to be updated as well. 
> From discussion on PR 1986: 
> {quote}
> Also, as @joewitt noted earlier, we should change the available interface for other "listener"
processors. Here's a preliminary list I put together, but I would like confirmation from another
> * `HandleHTTPRequest`
> * `ListenBeats`
> * `DistributedCacheServer`/`DistributedSetCacheServer`/`DistributedMapCacheServer`
> * `ListenSMTP`
> * `ListenGRPC`
> * `ListenLumberjack` (*Deprecated*)
> * `ListenRELP`
> * `ListenSyslog`
> * `ListenTCP`/`ListenTCPRecord`
> Also:
> * `AbstractSiteToSiteReportingTask`
> * `org.apache.nifi.processors.slack.TestServer`
> * `WebSocketService`/`JettyWebSocketService`
> {quote}

This message was sent by Atlassian JIRA

View raw message