nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-3950) Separate AWS ControllerService API
Date Sun, 10 Sep 2017 21:23:00 GMT

    [ https://issues.apache.org/jira/browse/NIFI-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160483#comment-16160483
] 

ASF GitHub Bot commented on NIFI-3950:
--------------------------------------

GitHub user christophercurrie opened a pull request:

    https://github.com/apache/nifi/pull/2140

    NIFI-3950 Refactor AWS bundle

    This PR provides a separate NAR for the `AWSCredentialsProviderService` API, and a new
`nifi-aws-abstract-processors` jar so that custom processors can take advantage of the abstract
base classes without importing duplicates of the existing implementations.
    
    The JIRA ticket mentions the need for a transition plan; I'm not sure what is required
there, but happy to help provide whatever is needed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/christophercurrie/nifi NIFI-3950-aws-refactor

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2140
    
----
commit 1c30e78716dd9f592cdbe9abc583053cb7fcd31d
Author: Christopher Currie <christopher@currie.com>
Date:   2017-09-10T20:19:45Z

    NIFI-3950 Refactor AWS bundle

----


> Separate AWS ControllerService API
> ----------------------------------
>
>                 Key: NIFI-3950
>                 URL: https://issues.apache.org/jira/browse/NIFI-3950
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: James Wing
>            Priority: Minor
>
> The nifi-aws-bundle currently contains the interface for the AWSCredentialsProviderService
as well as the service implementation, and dependent abstract classes and processor classes.
> This results in the following warning logged as NiFi loads:
> {quote}
> org.apache.nifi.nar.ExtensionManager Component org.apache.nifi.processors.aws.s3.PutS3Object
is bundled with its referenced Controller Service APIs org.apache.nifi.processors.aws.credentials.provider.service.AWSCredentialsProviderService.
The service APIs should not be bundled with component implementations that reference it.
> {quote}
> Some [discussion of this issue and potential solutions occurred on the dev list|http://apache-nifi.1125220.n5.nabble.com/Duplicated-processors-when-using-nifi-processors-dependency-td17038.html].
> We also need a migration plan in addition to the new structure.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message