nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-3941) Clarify tab name for controller level controller services dialog
Date Fri, 01 Sep 2017 21:21:01 GMT

    [ https://issues.apache.org/jira/browse/NIFI-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151163#comment-16151163
] 

ASF GitHub Bot commented on NIFI-3941:
--------------------------------------

GitHub user yuri1969 opened a pull request:

    https://github.com/apache/nifi/pull/2124

    NIFI-3941 - Clarify tab name for controller...

    ...level controller services dialog
    
    * Changed the tab title since sharing the name makes things
    less clear for newcomers.
    * Suggested info sentence is omitted.
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying
to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check
clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file
under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file
found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic
access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yuri1969/nifi NIFI-3941

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2124
    
----
commit 2109cf8946a3b91247f40085396fc2559424e251
Author: yuri1969 <1969yuri1969@gmail.com>
Date:   2017-09-01T19:59:17Z

    NIFI-3941 - Clarify tab name for controller...
    
    ...level controller services dialog
    
    * Changed the tab title since sharing the name makes things
    less clear for newcomers.
    * Suggested info sentence is omitted.

----


> Clarify tab name for controller level controller services dialog
> ----------------------------------------------------------------
>
>                 Key: NIFI-3941
>                 URL: https://issues.apache.org/jira/browse/NIFI-3941
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core UI
>    Affects Versions: 1.2.0
>            Reporter: Andy LoPresto
>            Priority: Minor
>              Labels: label, ui
>
> As a follow-on to [NIFI-3911|https://issues.apache.org/jira/browse/NIFI-3911], I believe
the *Controller Services* tab in the "global"/"controller level" *Controller Settings* dialog
should be renamed to *Reporting Task Controller Services* and a sentence added above the table
explaining that any controller services added here are only accessible by reporting tasks
and not accessible by any components on the flow itself. 
> {quote}
> Would it make sense to change the title of the tab in the global Controller Settings
dialog to "Reporting Task Controller Services" and add a sentence description above the table
stating that these controller services are only accessible by the Reporting Tasks?
> {quote}
> This is helpful for users who do not read the extensive documentation in the User Guide.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message