nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JPercivall <...@git.apache.org>
Subject [GitHub] nifi issue #2154: NIFI-2663: Add WebSocket support for MQTT processors
Date Sun, 17 Sep 2017 23:14:23 GMT
Github user JPercivall commented on the issue:

    https://github.com/apache/nifi/pull/2154
  
    @SebastianCarroll the way the test cases are set up you don't need to copy and paste the
tests themselves. What you'll do is extend common/Test*MqttCommon in order to get all the
junit tests. See [TestPublishMQTT](https://github.com/apache/nifi/blob/7923fd04c35737df8145b213536bdf333ef72713/nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/test/java/org/apache/nifi/processors/mqtt/integration/TestPublishMQTT.java#L38)
in the integration folder as an example. 
    
    While it may be just a 3 letter change on our end, you're changing a core configuration
of the underlying implementation. So verifying that is helpful.
    
    Also, what is the purpose of the changes you've made to MqttTestClient.java and where
did you copy & paste the comments/code from?
    
    Lastly, you have some check style issues (can be seen by running "mvn clean install -Pcontrib-check").
Here's what I see:
    
    `[WARNING] src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java[104:52]
(whitespace) OperatorWrap: '||' should be on a new line.
    [WARNING] src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java[105:53]
(whitespace) OperatorWrap: '||' should be on a new line.
    [WARNING] src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java[106:52]
(whitespace) OperatorWrap: '||' should be on a new line.
    [WARNING] src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java[296:62]
(whitespace) OperatorWrap: '||' should be on a new line.
    [WARNING] src/test/java/org/apache/nifi/processors/mqtt/common/MqttTestClient.java[20]
(imports) AvoidStarImport: Using the '.*' form of import should be avoided - org.eclipse.paho.client.mqttv3.*.
    [WARNING] src/test/java/org/apache/nifi/processors/mqtt/common/MqttTestClient.java[375:43]
(whitespace) FileTabCharacter: Line contains a tab character.
    [WARNING] src/test/java/org/apache/nifi/processors/mqtt/common/MqttTestClient.java[476:43]
(whitespace) FileTabCharacter: Line contains a tab character.`


---

Mime
View raw message