nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (NIFIREG-6) Add nifi-registry-bootstrap module
Date Thu, 03 Aug 2017 14:06:04 GMT


ASF GitHub Bot commented on NIFIREG-6:

Github user mcgilman commented on a diff in the pull request:
    --- Diff: nifi-registry-runtime/src/main/java/org/apache/nifi/registry/
    @@ -18,22 +18,69 @@
     import org.apache.nifi.registry.jetty.JettyServer;
    +import org.apache.nifi.registry.util.FileUtils;
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
    +import org.slf4j.bridge.SLF4JBridgeHandler;
    +import java.lang.reflect.InvocationTargetException;
    +import java.nio.charset.StandardCharsets;
    +import java.nio.file.Files;
    +import java.nio.file.Paths;
    +import java.util.ArrayList;
    +import java.util.Arrays;
    +import java.util.List;
    +import java.util.Random;
    +import java.util.Timer;
    +import java.util.TimerTask;
    +import java.util.concurrent.Executors;
    +import java.util.concurrent.ScheduledExecutorService;
    +import java.util.concurrent.ScheduledFuture;
    +import java.util.concurrent.ThreadFactory;
    +import java.util.concurrent.TimeUnit;
    +import java.util.concurrent.atomic.AtomicInteger;
    +import java.util.concurrent.atomic.AtomicLong;
      * Main entry point for NiFiRegistry.
     public class NiFiRegistry {
    -    private static final Logger logger = LoggerFactory.getLogger(JettyServer.class);
    +    private static final Logger LOGGER = LoggerFactory.getLogger(NiFiRegistry.class);
    +    private static final String KEY_FILE_FLAG = "-K";
    -    private static JettyServer server;
    +    public static final String BOOTSTRAP_PORT_PROPERTY = "nifi.registry.bootstrap.listen.port";
    +    private final JettyServer server;
    +    private final BootstrapListener bootstrapListener;
    +    private volatile boolean shutdown = false;
    +    public NiFiRegistry(final NiFiRegistryProperties properties)
    +            throws ClassNotFoundException, IOException, NoSuchMethodException, InstantiationException,
IllegalAccessException, IllegalArgumentException, InvocationTargetException {
    +        // There can only be one krb5.conf for the overall Java process so set this globally
    +        // start up so that processors and our Kerberos authentication code don't have
to set this
    +        // TODO enable if we support Kerberos
    --- End diff --
    Should we remove this for now until we need to explicitly add support for it?

> Add nifi-registry-bootstrap module
> ----------------------------------
>                 Key: NIFIREG-6
>                 URL:
>             Project: NiFi Registry
>          Issue Type: Improvement
>    Affects Versions: 0.0.1
>            Reporter: Bryan Bende
>            Assignee: Bryan Bende
>            Priority: Minor
> Currently NiFiRegistry is the entry point of the application, and in its current state
the main method starts a new Jetty server every time.  
> We should take a similar approach to NiFi where we have a bootstrap process that launches
and communicates with the application process.

This message was sent by Atlassian JIRA

View raw message