[ https://issues.apache.org/jira/browse/NIFI-4215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113222#comment-16113222
]
ASF GitHub Bot commented on NIFI-4215:
--------------------------------------
GitHub user Wesley-Lawrence opened a pull request:
https://github.com/apache/nifi/pull/2052
NIFI-4215 NiFi can now parse an Avro schema of a record that referenc…
…es an already defined record, including itself.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [✓] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [✓] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
- [✓] Has your PR been rebased against the latest commit within the target branch (typically
master)?
- [✓] Is your initial contribution a single, squashed commit?
### For code changes:
- [✓] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check
clean install at the root nifi folder?
- [✓] Have you written or updated unit tests to verify your changes?
- [N/A] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [N/A] If applicable, have you updated the LICENSE file, including the main LICENSE file
under nifi-assembly?
- [N/A] If applicable, have you updated the NOTICE file, including the main NOTICE file
found under nifi-assembly?
- [N/A] If adding new Properties, have you added .displayName in addition to .name (programmatic
access) for each of the new properties?
### For documentation related changes:
- [N/A] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Wesley-Lawrence/nifi NIFI-4215
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2052.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2052
----
commit 2423fd346031bbb66124863250080b356d029d90
Author: Wesley-Lawrence <wesleyll505@gmail.com>
Date: 2017-08-03T17:48:31Z
NIFI-4215 NiFi can now parse an Avro schema of a record that references an already defined
record, including itself.
----
> Avro schemas with records that have a field of themselves fail to parse, causing stackoverflow
exception
> --------------------------------------------------------------------------------------------------------
>
> Key: NIFI-4215
> URL: https://issues.apache.org/jira/browse/NIFI-4215
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.4.0
> Reporter: Wesley L Lawrence
> Priority: Minor
> Attachments: nifi-4215.patch
>
>
> Noticed this while attempting to use the AvroSchemaRegsitry with some complex schema.
Boiled down, Avro lets you define a schema such as;
> {code}
> {
> "namespace": "org.apache.nifi.testing",
> "name": "CompositRecord",
> "type": "record",
> "fields": [
> {
> "name": "id",
> "type": "int"
> },
> {
> "name": "value",
> "type": "string"
> },
> {
> "name": "parent",
> "type": [
> "null",
> "CompositRecord"
> ]
> }
> ]
> }
> {code}
> The AvroSchemaRegistry (AvroTypeUtil specifically) will fail to parse, and generate a
stackoverflow exception.
> I've whipped up a fix, tested it out in 1.4.0, and am just running through the contrib
build before I submit a patch.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
|