nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (NIFI-4139) Refactor KeyProvider interface from provenance module to framework-level service
Date Tue, 01 Aug 2017 01:21:00 GMT


ASF GitHub Bot commented on NIFI-4139:

GitHub user alopresto opened a pull request:

    NIFI-4139 Extract key provider to framework-level service

    Thank you for submitting a contribution to Apache NiFi.
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying
to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically
    - [ ] Is your initial contribution a single, squashed commit?
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check
clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](

    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file
under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file
found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic
access) for each of the new properties?
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.

You can merge this pull request into a Git repository by running:

    $ git pull NIFI-4139

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2044
commit 8e188c3463958902b0ac96583ee28e0abd558fa3
Author: Andy LoPresto <>
Date:   2017-07-28T00:11:10Z

    NIFI-4139 Moved key provider interface and implementations from nifi-data-provenance-utils
module to nifi-security-utils module.

commit 7c5729b792128717835653773828623cfd354d5b
Author: Andy LoPresto <>
Date:   2017-07-28T00:42:04Z

    NIFI-4139 Refactored duplicate byte[] concatenation methods from utility classes and removed
deprecation warnings from CipherUtility.

commit fc10d4c52b9de651443e69b306355b0eb72621e1
Author: Andy LoPresto <>
Date:   2017-07-28T17:50:58Z

    NIFI-4139 Created KeyProviderFactory to encapsulate key provider instantiation logic.

commit c9a644a8404c50f13442c65d2ea5e9476f379d44
Author: Andy LoPresto <>
Date:   2017-07-31T22:29:47Z

    NIFI-4139 Added logic to handle legacy package configuration values for key providers.
    Added unit tests.
    Added resource files for un/limited strength cryptography scenarios.

commit 70e3a181336bd016510bf59b4be80a9d249f6395
Author: Andy LoPresto <>
Date:   2017-07-31T22:33:55Z

    NIFI-4139 Added ASL to test resources.

commit b9f3e956608e57d05be3f47869cdd08bb496627d
Author: Andy LoPresto <>
Date:   2017-08-01T00:33:10Z

    NIFI-4139 Moved legacy FQCN handling logic to CryptUtils.
    Added unit tests to ensure application startup logic handles legacy FQCNs.


> Refactor KeyProvider interface from provenance module to framework-level service
> --------------------------------------------------------------------------------
>                 Key: NIFI-4139
>                 URL:
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: 1.3.0
>            Reporter: Andy LoPresto
>            Assignee: Andy LoPresto
>              Labels: encryption, key-management, security
> The {{KeyProvider}} interface introduced in NIFI-3388 to allow the encrypted provenance
repository should be refactored to a framework-level service which is accessible to the encrypted
content repository and encrypted flowfile repository as well. Exposing this common functionality
will reduce code & logic duplication and consolidate sensitive behavior in a single location.

This message was sent by Atlassian JIRA

View raw message