nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-4051) QueryRecord uses a different Lexical policy for validation than it does for running
Date Thu, 03 Aug 2017 20:57:00 GMT

    [ https://issues.apache.org/jira/browse/NIFI-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113469#comment-16113469
] 

ASF GitHub Bot commented on NIFI-4051:
--------------------------------------

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/2054

    NIFI-4051: Ensure that we use the appropriate Lexical syntax for SQL …

    …query validation as we do when running
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying
to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check
clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file
under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file
found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic
access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-4051

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2054.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2054
    
----
commit 1e7aa95ad6abd177069507883d84e3380f879207
Author: Mark Payne <markap14@hotmail.com>
Date:   2017-08-03T20:56:10Z

    NIFI-4051: Ensure that we use the appropriate Lexical syntax for SQL query validation
as we do when running

----


> QueryRecord uses a different Lexical policy for validation than it does for running
> -----------------------------------------------------------------------------------
>
>                 Key: NIFI-4051
>                 URL: https://issues.apache.org/jira/browse/NIFI-4051
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>             Fix For: 1.4.0
>
>
> The SqlParser used by the SqlValidator for QueryRecord does not specify the Lexical policy.
However, when running, we use the MYSQL_ANSI policy. The validator should be updated to also
use the MYSQL_ANSI policy.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message