nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-1027) Treat label and node of a provenance graph event as one unit
Date Sat, 05 Aug 2017 15:16:00 GMT

    [ https://issues.apache.org/jira/browse/NIFI-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115426#comment-16115426
] 

ASF GitHub Bot commented on NIFI-1027:
--------------------------------------

GitHub user yuri1969 opened a pull request:

    https://github.com/apache/nifi/pull/2059

    NIFI-1027 - Treat label and node of a provenance

    ...graph event as one unit
    
    The JIRA issue asks for treating both node and its label as one unit.
    Described cursor issues seems to be fixed already.
    
    However, there is an annoying dead space between a node and label
    preventing displaying context menu, etc. Due to SVG group's nature
    there has been added an opaque joint to remove the dead space.
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying
to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically
master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check
clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file
under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file
found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic
access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yuri1969/nifi NIFI-1027

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2059.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2059
    
----
commit 77511871ed13935abfac1aae0e9e8b0473f17d71
Author: yuri1969 <1969yuri1969@gmail.com>
Date:   2017-08-05T14:57:48Z

    NIFI-1027 - Treat label and node of a provenance
    
    ...graph event as one unit
    
    The JIRA issue asks for treating both node and its label as one unit.
    Described cursor issues seems to be fixed already.
    
    However, there is an annoying dead space between a node and label
    preventing displaying context menu, etc. Due to SVG group's nature
    there has been added an opaque joint to remove the dead space.

----


> Treat label and node of a provenance graph event as one unit
> ------------------------------------------------------------
>
>                 Key: NIFI-1027
>                 URL: https://issues.apache.org/jira/browse/NIFI-1027
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core UI
>    Affects Versions: 0.3.0
>            Reporter: Aldrin Piri
>            Priority: Minor
>
> Interactions with provenance graph events can be unintuitive for user interaction. If
navigating a graph, the labels on a provenance event node (JOIN, DROP, etc) cause a cursor
change when hovering over the text label for that node but this does not allow any interaction
with the event.  In contrast, hovering over the actual node itself, there is no cursor indication
but is where the actions must occur.
> It would be more intuitive if the node and its label were one unit, the entirety of which
was actionable for interaction with the event.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message