Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D5FF8200B95 for ; Mon, 12 Sep 2016 22:26:23 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D4877160AB2; Mon, 12 Sep 2016 20:26:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2FE1C160AC8 for ; Mon, 12 Sep 2016 22:26:23 +0200 (CEST) Received: (qmail 65905 invoked by uid 500); 12 Sep 2016 20:26:21 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 65546 invoked by uid 99); 12 Sep 2016 20:26:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Sep 2016 20:26:21 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id DDB122C1B7D for ; Mon, 12 Sep 2016 20:26:20 +0000 (UTC) Date: Mon, 12 Sep 2016 20:26:20 +0000 (UTC) From: "Joe Skora (JIRA)" To: issues@nifi.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (NIFI-2752) Correct ReplaceText default pattern and unit tests MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 12 Sep 2016 20:26:24 -0000 [ https://issues.apache.org/jira/browse/NIFI-2752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Skora updated NIFI-2752: ---------------------------- Status: Patch Available (was: In Progress) https://github.com/apache/nifi/pull/1007 > Correct ReplaceText default pattern and unit tests > -------------------------------------------------- > > Key: NIFI-2752 > URL: https://issues.apache.org/jira/browse/NIFI-2752 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework > Affects Versions: 1.1.0, 0.8.0, 0.7.1 > Reporter: Joe Skora > Assignee: Joe Skora > > [{{ReplaceText.DEFAULT_REGEX}}|https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ReplaceText.java#L87] is defined as "(?s:\^.\*$)", which is valid PCRE but must be expressed as "(?s)(\^.\*$)" in Java. > The Java [Pattern class|https://docs.oracle.com/javase/8/docs/api/index.html] specifies that patterns like "(?idmsux-idmsux:X)" are _non-capturing_, so anything but the default pattern and replacement value result in empty output. This isn't caught by unit tests because the code short circuits if the default pattern and replacement are found in [ReplaceText.onTrigger()|https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ReplaceText.java#L217]. This hides the capture group problem from the unit tests and the default processor configuration, but causes the processor to produce empty output if using non-trivial patterns and replacements. -- This message was sent by Atlassian JIRA (v6.3.4#6332)