Mailing-List: contact commits-help@nifi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@nifi.apache.org
Date: Mon, 18 Dec 2017 15:24:02 +0000 (UTC)
From: "Aldrin Piri (JIRA)" <jira@apache.org>
To: commits@nifi.apache.org
Message-ID: <JIRA.13125645.1513610625000.483201.1513610642276@Atlassian.JIRA>
In-Reply-To: <JIRA.13125645.1513610625000@Atlassian.JIRA>
References: <JIRA.13125645.1513610625000@Atlassian.JIRA> <JIRA.13125645.1513610625712@jira-lw-us.apache.org>
Subject: [jira] [Created] (MINIFI-420) Cached Windows service executables
 can leak into generated source packages
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 18 Dec 2017 15:24:10 -0000

Aldrin Piri created MINIFI-420:
----------------------------------

             Summary: Cached Windows service executables can leak into generated source packages
                 Key: MINIFI-420
                 URL: https://issues.apache.org/jira/browse/MINIFI-420
             Project: Apache NiFi MiNiFi
          Issue Type: Improvement
          Components: Build
    Affects Versions: 0.3.0
            Reporter: Koji Kawamura
            Assignee: Aldrin Piri
             Fix For: 0.3.0


During the RC2 of the MiNiFi 0.3.0 release it was identified that the candidate source package had executables in it related to the Windows service enablement.  

The files are provided such that we cache them so that there is no need to repeatedly download the package assembly.

Given that .exe is also in .gitignore, a git clean -fd would not remove these. (-fxd would)

There are two options that come to mind to help remedy this issue and make things a bit less error prone.  One is to move the acquired executables and package to target.  However, given that most folks are likely to do a mvn clean <goals> this would likely defeat the purpose of caching entirely.  The other option is to provide configuration to the maven source plugin to exclude these items.  This would allow us to more effectively cache these items but also provide a clean source release that would function as anticipated on build.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)