Mailing-List: contact commits-help@nifi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@nifi.apache.org
Date: Thu, 5 Oct 2017 19:53:01 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@nifi.apache.org
Message-ID: <JIRA.13106568.1506982858000.282566.1507233181055@Atlassian.JIRA>
In-Reply-To: <JIRA.13106568.1506982858000@Atlassian.JIRA>
References: <JIRA.13106568.1506982858000@Atlassian.JIRA> <JIRA.13106568.1506982858889@jira-lw-us.apache.org>
Subject: [jira] [Commented] (MINIFI-404) Provide a source build of
 executables used for Windows or remove functionality
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 05 Oct 2017 19:53:08 -0000


    [ https://issues.apache.org/jira/browse/MINIFI-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193527#comment-16193527 ] 

ASF GitHub Bot commented on MINIFI-404:
---------------------------------------

Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/92#discussion_r143039965
  
    --- Diff: minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-resources/pom.xml ---
    @@ -25,6 +25,49 @@
         <description>holds common resources used to build installers</description>
         <build>
             <plugins>
    +        	<plugin>
    +				<groupId>org.apache.maven.plugins</groupId>
    +				<artifactId>maven-antrun-plugin</artifactId>
    +				<dependencies>
    +					<dependency>
    +						<groupId>ant-contrib</groupId>
    +						<artifactId>ant-contrib</artifactId>
    +						<version>20020829</version>
    +					</dependency>
    +				</dependencies>
    +				<executions>
    +					<execution>
    +						<id>download-commons-daemon</id>
    +						<phase>compile</phase>
    +						<goals>
    +							<goal>run</goal>
    +						</goals>
    +						<configuration>
    +							<tasks>
    +								<taskdef resource="net/sf/antcontrib/antcontrib.properties" />
    +								<if>
    +									<available file="${basedir}/src/main/resources/bin/minifiw.exe" />
    +									<then>
    +										<echo message="Skipping download of commons-daemon." />
    +									</then>
    +									<else>
    +										<get
    --- End diff --
    
    What do you think about adding a checksum/hash verification of the download to verify our build is okay?
    
    The Ant docs have a macro that accomplishes something like this: https://ant.apache.org/manual/Tasks/get.html


> Provide a source build of executables used for Windows or remove functionality
> ------------------------------------------------------------------------------
>
>                 Key: MINIFI-404
>                 URL: https://issues.apache.org/jira/browse/MINIFI-404
>             Project: Apache NiFi MiNiFi
>          Issue Type: Task
>          Components: Agent Configuration/Installation
>    Affects Versions: 0.2.0
>            Reporter: Aldrin Piri
>            Assignee: Jeff Zemerick
>            Priority: Blocker
>             Fix For: 0.3.0
>
>
> MINIFI-344 provided windows support making use of the Apache Daemon procrun.  This was accomplished by making use of those binaries and wrapping the application which is an issue for a proper source release.  We need to determine a way to generate these at build time (other Apache projects generate such artifacts and we should evaluate how those are accomplished).  Should no tenable solution be found before our next release, this will have to be removed until a time when we are able to.  In such a scenario,  we could capture this information in docs for those that are interested in doing so out of the community processes.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)