Mailing-List: contact commits-help@nifi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@nifi.apache.org
Date: Thu, 5 Oct 2017 18:12:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@nifi.apache.org
Message-ID: <JIRA.13106568.1506982858000.281514.1507227120610@Atlassian.JIRA>
In-Reply-To: <JIRA.13106568.1506982858000@Atlassian.JIRA>
References: <JIRA.13106568.1506982858000@Atlassian.JIRA> <JIRA.13106568.1506982858889@jira-lw-us.apache.org>
Subject: [jira] [Commented] (MINIFI-404) Provide a source build of
 executables used for Windows or remove functionality
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 05 Oct 2017 18:12:06 -0000


    [ https://issues.apache.org/jira/browse/MINIFI-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16193358#comment-16193358 ] 

ASF GitHub Bot commented on MINIFI-404:
---------------------------------------

GitHub user jzonthemtn opened a pull request:

    https://github.com/apache/nifi-minifi/pull/92

    MINIFI-404: Downloads Windows service binaries on build.

    Thank you for submitting a contribution to Apache NiFi - MiNiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jzonthemtn/nifi-minifi MINIFI-404

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi/pull/92.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #92
    
----
commit 6c9e8797071ab33dbe76369fa8228cf5c63295b9
Author: jzonthemtn <jzemerick@apache.org>
Date:   2017-10-05T18:01:58Z

    MINIFI-404: Downloads Windows service binaries on build.

----


> Provide a source build of executables used for Windows or remove functionality
> ------------------------------------------------------------------------------
>
>                 Key: MINIFI-404
>                 URL: https://issues.apache.org/jira/browse/MINIFI-404
>             Project: Apache NiFi MiNiFi
>          Issue Type: Task
>          Components: Agent Configuration/Installation
>    Affects Versions: 0.2.0
>            Reporter: Aldrin Piri
>            Assignee: Jeff Zemerick
>            Priority: Blocker
>             Fix For: 0.3.0
>
>
> MINIFI-344 provided windows support making use of the Apache Daemon procrun.  This was accomplished by making use of those binaries and wrapping the application which is an issue for a proper source release.  We need to determine a way to generate these at build time (other Apache projects generate such artifacts and we should evaluate how those are accomplished).  Should no tenable solution be found before our next release, this will have to be removed until a time when we are able to.  In such a scenario,  we could capture this information in docs for those that are interested in doing so out of the community processes.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)