Mailing-List: contact commits-help@nifi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@nifi.apache.org
Date: Fri, 8 Sep 2017 20:39:03 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@nifi.apache.org
Message-ID: <JIRA.13080861.1497885676000.64801.1504903143622@Atlassian.JIRA>
In-Reply-To: <JIRA.13080861.1497885676000@Atlassian.JIRA>
References: <JIRA.13080861.1497885676000@Atlassian.JIRA> <JIRA.13080861.1497885676264@jira-lw-us.apache.org>
Subject: [jira] [Commented] (MINIFI-339) Begin building controlling API to
 facilitate control of agents
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 08 Sep 2017 20:39:12 -0000


    [ https://issues.apache.org/jira/browse/MINIFI-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159284#comment-16159284 ] 

ASF GitHub Bot commented on MINIFI-339:
---------------------------------------

Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137861024
  
    --- Diff: libminifi/include/c2/C2Protocol.h ---
    @@ -0,0 +1,119 @@
    +/**
    + *
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +#ifndef LIBMINIFI_INCLUDE_C2_C2PROTOCOL_H_
    +#define LIBMINIFI_INCLUDE_C2_C2PROTOCOL_H_
    +
    +#include "C2Payload.h"
    +#include "core/controller/ControllerServiceProvider.h"
    +#include "properties/Configure.h"
    +#include "core/Connectable.h"
    +namespace org {
    +namespace apache {
    +namespace nifi {
    +namespace minifi {
    +namespace c2 {
    +
    +/**
    + * Defines a protocol to perform state management of the minifi agent.
    + */
    +class C2Protocol : public core::Connectable {
    + public:
    +
    +  C2Protocol(std::string name, uuid_t uuid)
    +      : core::Connectable(name, uuid),
    +        running_(true) {
    +
    +  }
    +
    +  virtual void initialize(const std::shared_ptr<core::controller::ControllerServiceProvider> &controller, const std::shared_ptr<Configure> &configure) {
    +    controller_ = controller;
    +    configuration_ = configure;
    +  }
    +  virtual ~C2Protocol() {
    +
    +  }
    +
    +  /**
    +   * Update the configuration.
    +   */
    +  virtual void update(const std::shared_ptr<Configure> &configure)=0;
    +
    +  /**
    +   * Send a C2 payload to the provided URI. The direction indicates to the protocol whether or not this a transmit or receive operatin.
    +   * Depending on the protocol this may mean different things.
    +   *
    +   * @param url url.
    +   * @param operation payload to perform and/or send
    +   * @param direction direction of the C2 operation.
    +   * @param async whether or not this is an asynchronous operation
    +   * @return payload from the response or a response to come back in the face of an asynchronous operation.
    +   */
    +  virtual C2Payload consumePayload(const std::string &url, const C2Payload &operation, Direction direction = TRANSMIT, bool async = false) = 0;
    +
    +  /**
    +   * Send a C2 payload . The direction indicates to the protocol whether or not this a transmit or receive operatin.
    --- End diff --
    
    Minor typo.


> Begin building controlling API to facilitate control of agents
> --------------------------------------------------------------
>
>                 Key: MINIFI-339
>                 URL: https://issues.apache.org/jira/browse/MINIFI-339
>             Project: Apache NiFi MiNiFi
>          Issue Type: New Feature
>          Components: C++
>            Reporter: marco polo
>            Assignee: marco polo
>            Priority: Critical
>              Labels: Durability, Reliability, Statistics
>
> Begin building the controlling API in MiNiFi C++. This API will evolve and likely have public and private elements. As development progresses we may want more capabilities. 
> What I want to create as a straw man will be basic control and metrics gathering
> -- Start
> -- Stop
> -- Pause
> -- Gather metrics
>    ** Throughput of of flow components
>    ** Execution time ( run time minus sleep time )
>    ** Memory consumption
> -- Drain repositories
> -- Switch repository types. 
> Better employ update listener within this controlling API


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)