Mailing-List: contact commits-help@nifi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@nifi.apache.org
Date: Fri, 8 Sep 2017 20:39:02 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@nifi.apache.org
Message-ID: <JIRA.13080861.1497885676000.64756.1504903142473@Atlassian.JIRA>
In-Reply-To: <JIRA.13080861.1497885676000@Atlassian.JIRA>
References: <JIRA.13080861.1497885676000@Atlassian.JIRA> <JIRA.13080861.1497885676264@jira-lw-us.apache.org>
Subject: [jira] [Commented] (MINIFI-339) Begin building controlling API to
 facilitate control of agents
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 08 Sep 2017 20:39:10 -0000


    [ https://issues.apache.org/jira/browse/MINIFI-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159269#comment-16159269 ] 

ASF GitHub Bot commented on MINIFI-339:
---------------------------------------

Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137812730
  
    --- Diff: libminifi/include/FlowController.h ---
    @@ -124,14 +123,33 @@ class FlowController : public core::controller::ControllerServiceProvider, publi
       virtual bool isRunning() {
         return running_.load();
       }
    +
       // Whether the Flow Controller has already been initialized (loaded flow XML)
       virtual bool isInitialized() {
         return initialized_.load();
       }
       // Start to run the Flow Controller which internally start the root process group and all its children
    -  virtual bool start();
    +  virtual int16_t start();
    --- End diff --
    
    For cases where we are overriding a member function already declared virtual in the base class, the virtual keyword is redundant. For this case and others like it, it would be better to use the override keyword so the compiler will check that the function is indeed overridden as expected.


> Begin building controlling API to facilitate control of agents
> --------------------------------------------------------------
>
>                 Key: MINIFI-339
>                 URL: https://issues.apache.org/jira/browse/MINIFI-339
>             Project: Apache NiFi MiNiFi
>          Issue Type: New Feature
>          Components: C++
>            Reporter: marco polo
>            Assignee: marco polo
>            Priority: Critical
>              Labels: Durability, Reliability, Statistics
>
> Begin building the controlling API in MiNiFi C++. This API will evolve and likely have public and private elements. As development progresses we may want more capabilities. 
> What I want to create as a straw man will be basic control and metrics gathering
> -- Start
> -- Stop
> -- Pause
> -- Gather metrics
>    ** Throughput of of flow components
>    ** Execution time ( run time minus sleep time )
>    ** Memory consumption
> -- Drain repositories
> -- Switch repository types. 
> Better employ update listener within this controlling API


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)