Mailing-List: contact commits-help@nifi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@nifi.apache.org
Date: Fri, 8 Sep 2017 20:39:02 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@nifi.apache.org
Message-ID: <JIRA.13080861.1497885676000.64747.1504903142378@Atlassian.JIRA>
In-Reply-To: <JIRA.13080861.1497885676000@Atlassian.JIRA>
References: <JIRA.13080861.1497885676000@Atlassian.JIRA> <JIRA.13080861.1497885676264@jira-lw-us.apache.org>
Subject: [jira] [Commented] (MINIFI-339) Begin building controlling API to
 facilitate control of agents
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 08 Sep 2017 20:39:07 -0000


    [ https://issues.apache.org/jira/browse/MINIFI-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159266#comment-16159266 ] 

ASF GitHub Bot commented on MINIFI-339:
---------------------------------------

Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137811526
  
    --- Diff: libminifi/include/FlowController.h ---
    @@ -124,14 +123,33 @@ class FlowController : public core::controller::ControllerServiceProvider, publi
       virtual bool isRunning() {
         return running_.load();
       }
    +
       // Whether the Flow Controller has already been initialized (loaded flow XML)
       virtual bool isInitialized() {
         return initialized_.load();
       }
       // Start to run the Flow Controller which internally start the root process group and all its children
    -  virtual bool start();
    +  virtual int16_t start();
    +  virtual int16_t pause() {
    +    return -1;
    +  }
       // Unload the current flow YAML, clean the root process group and all its children
    -  virtual void stop(bool force);
    +  virtual int16_t stop(bool force, uint64_t timeToWait = 0);
    +  virtual int16_t applyUpdate(const std::string &configuration);
    +  virtual int16_t drainRepositories() {
    +
    +    return -1;
    +  }
    +
    +  virtual std::vector<std::shared_ptr<state::StateController>> getComponents(const std::string &name);
    +
    +  virtual std::vector<std::shared_ptr<StateController>> getAllComponents();
    --- End diff --
    
    Missing state:: prefix on StateController type makes this signature declaration inconsistent with its implementation/other uses. Mostly cosmetic?


> Begin building controlling API to facilitate control of agents
> --------------------------------------------------------------
>
>                 Key: MINIFI-339
>                 URL: https://issues.apache.org/jira/browse/MINIFI-339
>             Project: Apache NiFi MiNiFi
>          Issue Type: New Feature
>          Components: C++
>            Reporter: marco polo
>            Assignee: marco polo
>            Priority: Critical
>              Labels: Durability, Reliability, Statistics
>
> Begin building the controlling API in MiNiFi C++. This API will evolve and likely have public and private elements. As development progresses we may want more capabilities. 
> What I want to create as a straw man will be basic control and metrics gathering
> -- Start
> -- Stop
> -- Pause
> -- Gather metrics
>    ** Throughput of of flow components
>    ** Execution time ( run time minus sleep time )
>    ** Memory consumption
> -- Drain repositories
> -- Switch repository types. 
> Better employ update listener within this controlling API


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)