nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MINIFI-339) Begin building controlling API to facilitate control of agents
Date Fri, 08 Sep 2017 20:39:03 GMT

    [ https://issues.apache.org/jira/browse/MINIFI-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159291#comment-16159291
] 

ASF GitHub Bot commented on MINIFI-339:
---------------------------------------

Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137880036
  
    --- Diff: libminifi/include/utils/HTTPClient.h ---
    @@ -0,0 +1,270 @@
    +/**
    + * HTTPUtils class declaration
    + *
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +#ifndef __HTTP_UTILS_H__
    +#define __HTTP_UTILS_H__
    +
    +#include <curl/curl.h>
    +#include <vector>
    +#include <iostream>
    +#include <string>
    +#include <curl/easy.h>
    +#include <uuid/uuid.h>
    +#include <regex.h>
    +#include <vector>
    +#include "controllers/SSLContextService.h"
    +#include "ByteInputCallBack.h"
    +#include "core/logging/Logger.h"
    +#include "core/logging/LoggerConfiguration.h"
    +#include "properties/Configure.h"
    +#include "io/validation.h"
    +
    +namespace org {
    +namespace apache {
    +namespace nifi {
    +namespace minifi {
    +namespace utils {
    +
    +struct HTTPUploadCallback {
    +  ByteInputCallBack *ptr;
    +  size_t pos;
    +};
    +
    +/**
    + * HTTP Response object
    + */
    +struct HTTPRequestResponse {
    +  std::vector<char> data;
    +
    +  /**
    +   * Receive HTTP Response.
    +   */
    +  static size_t recieve_write(char * data, size_t size, size_t nmemb,
    +                              void * p) {
    +    return static_cast<HTTPRequestResponse*>(p)->write_content(data, size,
    +                                                               nmemb);
    +  }
    +
    +  /**
    +   * Callback for post, put, and patch operations
    +   * @param buffer
    +   * @param size size of buffer
    +   * @param nitems items to add
    +   * @param insteam input stream object.
    +   */
    +
    +  static size_t send_write(char * data, size_t size, size_t nmemb, void * p) {
    +    if (p != 0) {
    +      HTTPUploadCallback *callback = (HTTPUploadCallback*) p;
    +      if (callback->pos <= callback->ptr->getBufferSize()) {
    +        char *ptr = callback->ptr->getBuffer();
    +        int len = callback->ptr->getBufferSize() - callback->pos;
    +        if (len <= 0) {
    +          return 0;
    +        }
    +        if (len > size * nmemb)
    +          len = size * nmemb;
    +        memcpy(data, callback->ptr->getBuffer() + callback->pos, len);
    +        callback->pos += len;
    +        return len;
    +      }
    +    } else {
    +      return CURL_READFUNC_ABORT;
    +    }
    +
    +    return 0;
    +  }
    +
    +  size_t write_content(char* ptr, size_t size, size_t nmemb) {
    +    data.insert(data.end(), ptr, ptr + size * nmemb);
    +    return size * nmemb;
    +  }
    +
    +};
    +
    +static void parse_url(std::string &url, std::string &host, int &port, std::string
&protocol) {
    +
    --- End diff --
    
    Debating whether or not it's a good idea to parse URLs with our own code here. On one
hand, it reduces the need for any library calls, but on the other hand it could get complex
to support everything according to spec.


> Begin building controlling API to facilitate control of agents
> --------------------------------------------------------------
>
>                 Key: MINIFI-339
>                 URL: https://issues.apache.org/jira/browse/MINIFI-339
>             Project: Apache NiFi MiNiFi
>          Issue Type: New Feature
>          Components: C++
>            Reporter: marco polo
>            Assignee: marco polo
>            Priority: Critical
>              Labels: Durability, Reliability, Statistics
>
> Begin building the controlling API in MiNiFi C++. This API will evolve and likely have
public and private elements. As development progresses we may want more capabilities. 
> What I want to create as a straw man will be basic control and metrics gathering
> -- Start
> -- Stop
> -- Pause
> -- Gather metrics
>    ** Throughput of of flow components
>    ** Execution time ( run time minus sleep time )
>    ** Memory consumption
> -- Drain repositories
> -- Switch repository types. 
> Better employ update listener within this controlling API



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message