nifi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MINIFI-339) Begin building controlling API to facilitate control of agents
Date Fri, 08 Sep 2017 20:39:02 GMT

    [ https://issues.apache.org/jira/browse/MINIFI-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159267#comment-16159267
] 

ASF GitHub Bot commented on MINIFI-339:
---------------------------------------

Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/134#discussion_r137817535
  
    --- Diff: libminifi/include/FlowController.h ---
    @@ -158,7 +176,7 @@ class FlowController : public core::controller::ControllerServiceProvider,
publi
       // first it will validate the payload with the current root node config for flowController
       // like FlowController id/name is the same and new version is greater than the current
version
       // after that, it will apply the configuration
    -  bool applyConfiguration(std::string &configurePayload);
    +  bool applyConfiguration(const std::string &configurePayload);
    --- End diff --
    
    I don't think 339 introduced this, but we are very tightly coupled with YAML (and strings)
here. FlowController should ideally be agnostic to configuration formats and take in/apply
some kind of abstract config structure.


> Begin building controlling API to facilitate control of agents
> --------------------------------------------------------------
>
>                 Key: MINIFI-339
>                 URL: https://issues.apache.org/jira/browse/MINIFI-339
>             Project: Apache NiFi MiNiFi
>          Issue Type: New Feature
>          Components: C++
>            Reporter: marco polo
>            Assignee: marco polo
>            Priority: Critical
>              Labels: Durability, Reliability, Statistics
>
> Begin building the controlling API in MiNiFi C++. This API will evolve and likely have
public and private elements. As development progresses we may want more capabilities. 
> What I want to create as a straw man will be basic control and metrics gathering
> -- Start
> -- Stop
> -- Pause
> -- Gather metrics
>    ** Throughput of of flow components
>    ** Execution time ( run time minus sleep time )
>    ** Memory consumption
> -- Drain repositories
> -- Switch repository types. 
> Better employ update listener within this controlling API



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message