Mailing-List: contact commits-help@nifi.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@nifi.apache.org
Date: Thu, 4 May 2017 18:59:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@nifi.apache.org
Message-ID: <JIRA.13068930.1493845524000.129557.1493924344514@Atlassian.JIRA>
In-Reply-To: <JIRA.13068930.1493845524000@Atlassian.JIRA>
References: <JIRA.13068930.1493845524000@Atlassian.JIRA> <JIRA.13068930.1493845524567@jira-lw-us.apache.org>
Subject: [jira] [Commented] (MINIFI-294) Better handling of required vs.
 optional fields in config schema v1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 04 May 2017 18:59:10 -0000


    [ https://issues.apache.org/jira/browse/MINIFI-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997234#comment-15997234 ] 

ASF GitHub Bot commented on MINIFI-294:
---------------------------------------

Github user apiri commented on the issue:

    https://github.com/apache/nifi-minifi-cpp/pull/90
  
    @kevdoran,
    
    Changes look good.  Ran against some sample configs and things work as anticipated.  Thanks for correcting this!  Will get merged.


> Better handling of required vs. optional fields in config schema v1
> -------------------------------------------------------------------
>
>                 Key: MINIFI-294
>                 URL: https://issues.apache.org/jira/browse/MINIFI-294
>             Project: Apache NiFi MiNiFi
>          Issue Type: Bug
>          Components: C++, Documentation, Processing Configuration
>            Reporter: Kevin Doran
>            Assignee: Kevin Doran
>            Priority: Critical
>             Fix For: cpp-0.2.0
>
>
> This is a followup task to MINIFI-275. While the scope of MINIFI-275 was minifi-cpp processing of components without id fields, which are optional in config schema v1, this ticket covers all fields for all component types, either doing string checks for required fields (with useful error messages if absent) or graceful handling of missing optional fields.
> The Config Schema V1 in the minifi-java codebase will be used as a guide for which fields to treat as required and which to treat as optional. [~aldrin] - please confirm that is the correct assumption for minifi-cpp. The Java implementation can be found at [1]. Specifically, in the Java code, required fields are loaded using `getRequiredKeyAsType() and optional fields are loaded using `getOptionalKeyAsType()`
> Also in scope for this ticket is to update the config.yml examples in the minifi-cpp README.md file to make sure they are not missing required fields. During testing, it was found that one example config.yml is missing source name and destination name, which are required in config schema v1.
> [1] https://github.com/apache/nifi-minifi/tree/master/minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/v1


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)