Return-Path: X-Original-To: apmail-nifi-commits-archive@minotaur.apache.org Delivered-To: apmail-nifi-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 347B017E86 for ; Mon, 2 Mar 2015 04:04:19 +0000 (UTC) Received: (qmail 92880 invoked by uid 500); 2 Mar 2015 04:04:19 -0000 Delivered-To: apmail-nifi-commits-archive@nifi.apache.org Received: (qmail 92843 invoked by uid 500); 2 Mar 2015 04:04:19 -0000 Mailing-List: contact commits-help@nifi.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.incubator.apache.org Delivered-To: mailing list commits@nifi.incubator.apache.org Received: (qmail 92834 invoked by uid 99); 2 Mar 2015 04:04:19 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Mar 2015 04:04:19 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 02 Mar 2015 04:03:49 +0000 Received: (qmail 88554 invoked by uid 99); 2 Mar 2015 04:03:40 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Mar 2015 04:03:40 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 681A8E1023; Mon, 2 Mar 2015 04:03:40 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: joewitt@apache.org To: commits@nifi.incubator.apache.org Date: Mon, 02 Mar 2015 04:04:08 -0000 Message-Id: <9634d00a34534a059fe430a1ad1ab740@git.apache.org> In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [29/50] [abbrv] incubator-nifi git commit: NIFI-366: removed logic to check for invalid ports and throw exception if all ports are invalid. Instead, we will now just run but will be unable to transfer any data; this is preferred anyone because we should X-Virus-Checked: Checked by ClamAV on apache.org NIFI-366: removed logic to check for invalid ports and throw exception if all ports are invalid. Instead, we will now just run but will be unable to transfer any data; this is preferred anyone because we should still allow the state to be set to transmit, so that when the ports are no longer invalid we can start transmitting immediately. Project: http://git-wip-us.apache.org/repos/asf/incubator-nifi/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-nifi/commit/e370d7d7 Tree: http://git-wip-us.apache.org/repos/asf/incubator-nifi/tree/e370d7d7 Diff: http://git-wip-us.apache.org/repos/asf/incubator-nifi/diff/e370d7d7 Branch: refs/heads/NIFI-360 Commit: e370d7d7e3a78acdda5f7a3bc6d3c0a87768f7fa Parents: d8954ab Author: Mark Payne Authored: Tue Feb 24 14:03:00 2015 -0500 Committer: Mark Payne Committed: Tue Feb 24 14:03:00 2015 -0500 ---------------------------------------------------------------------- .../nifi/remote/StandardRemoteProcessGroup.java | 44 -------------------- 1 file changed, 44 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-nifi/blob/e370d7d7/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/remote/StandardRemoteProcessGroup.java ---------------------------------------------------------------------- diff --git a/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/remote/StandardRemoteProcessGroup.java b/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/remote/StandardRemoteProcessGroup.java index 6b70fe6..55575c6 100644 --- a/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/remote/StandardRemoteProcessGroup.java +++ b/nifi/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/remote/StandardRemoteProcessGroup.java @@ -915,50 +915,6 @@ public class StandardRemoteProcessGroup implements RemoteProcessGroup { try { verifyCanStartTransmitting(); - // Check if any port is invalid - boolean invalidPort = false; - for (final Port port : getInputPorts()) { - if (!port.isValid()) { - invalidPort = true; - break; - } - } - - if (!invalidPort) { - for (final Port port : getOutputPorts()) { - if (!port.isValid()) { - invalidPort = true; - } - } - } - - // if any port is invalid, refresh contents to check if it is still invalid - boolean allPortsInvalid = invalidPort; - if (invalidPort) { - try { - refreshFlowContents(); - } catch (final CommunicationsException e) { - logger.warn("{} Attempted to refresh Flow Contents because at least one port is invalid but failed due to {}", this, e); - } - - for (final Port port : getInputPorts()) { - if (port.isValid()) { - allPortsInvalid = false; - break; - } - } - for (final Port port : getOutputPorts()) { - if (port.isValid()) { - allPortsInvalid = false; - break; - } - } - } - - if (allPortsInvalid) { - throw new IllegalStateException("Cannot Enable Transmission because all Input Ports & Output Ports to this Remote Process Group are in invalid states"); - } - for (final Port port : getInputPorts()) { // if port is not valid, don't start it because it will never become valid. // Validation is based on connections and whether or not the remote target exists.