Return-Path: X-Original-To: apmail-nifi-commits-archive@minotaur.apache.org Delivered-To: apmail-nifi-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 53404175DF for ; Tue, 13 Jan 2015 18:38:09 +0000 (UTC) Received: (qmail 74571 invoked by uid 500); 13 Jan 2015 18:38:11 -0000 Delivered-To: apmail-nifi-commits-archive@nifi.apache.org Received: (qmail 74528 invoked by uid 500); 13 Jan 2015 18:38:10 -0000 Mailing-List: contact commits-help@nifi.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.incubator.apache.org Delivered-To: mailing list commits@nifi.incubator.apache.org Received: (qmail 74519 invoked by uid 99); 13 Jan 2015 18:38:10 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jan 2015 18:38:10 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 13 Jan 2015 18:38:09 +0000 Received: (qmail 62466 invoked by uid 99); 13 Jan 2015 18:36:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Jan 2015 18:36:35 +0000 Date: Tue, 13 Jan 2015 18:36:34 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: commits@nifi.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (NIFI-241) Framework FingerprintFactory begins processor life cycle but does not finish MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/NIFI-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275675#comment-14275675 ] ASF subversion and git services commented on NIFI-241: ------------------------------------------------------ Commit 21e809a7cbb85f450749916e474dec93f0d023d6 in incubator-nifi's branch refs/heads/develop from [~markap14] [ https://git-wip-us.apache.org/repos/asf?p=incubator-nifi.git;h=21e809a ] NIFI-241: Only call Processor methods with @OnAdded annotation when a Processor is actually added to graph instead of also calling on NiFi restart > Framework FingerprintFactory begins processor life cycle but does not finish > ---------------------------------------------------------------------------- > > Key: NIFI-241 > URL: https://issues.apache.org/jira/browse/NIFI-241 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework > Reporter: Michael Moser > Assignee: Mark Payne > Fix For: 0.0.1 > > Attachments: 0001-NIFI-241-Only-call-Processor-methods-with-OnAdded-an.patch > > > The FingerprintFactory will create Processor objects and invoke their initialize() and @OnAdded methods. If a Processor uses system resources, these methods are where those resources are allocated. But, those processors are never disposed by calling their @OnRemoved or @OnShutdown methods. This may result in system resource leaks, depending on how processors are implemented. > To reproduce, add a processor to the NiFi graph and restart NiFi. Note that initialize() and @OnAdded is called at least twice (I observed 3 times) as NiFi starts. The getIdentifier() is different for each invocation. Shutdown NiFi and observe that @OnShutdown is called once. -- This message was sent by Atlassian JIRA (v6.3.4#6332)