Return-Path: <dev-return-4158-archive-asf-public=cust-asf.ponee.io@netbeans.incubator.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id AF6E8200D39
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Sat, 28 Oct 2017 00:12:04 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id ADD61160BF4; Fri, 27 Oct 2017 22:12:04 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id F3567160BF2
	for <archive-asf-public@cust-asf.ponee.io>; Sat, 28 Oct 2017 00:12:03 +0200 (CEST)
Received: (qmail 43202 invoked by uid 500); 27 Oct 2017 22:12:03 -0000
Mailing-List: contact dev-help@netbeans.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@netbeans.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@netbeans.incubator.apache.org>
List-Post: <mailto:dev@netbeans.incubator.apache.org>
List-Id: <dev.netbeans.incubator.apache.org>
Reply-To: dev@netbeans.incubator.apache.org
Delivered-To: mailing list dev@netbeans.incubator.apache.org
Received: (qmail 43189 invoked by uid 99); 27 Oct 2017 22:12:03 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Oct 2017 22:12:03 +0000
From: GitBox <git@apache.org>
To: dev@netbeans.apache.org
Subject: [GitHub] vieiro commented on a change in pull request #181: [NETBEANS-54] Module Review libs.osgi (followup)
Message-ID: <150914232251.618.18356811416614047384.gitbox@gitbox.apache.org>
archived-at: Fri, 27 Oct 2017 22:12:04 -0000

vieiro commented on a change in pull request #181: [NETBEANS-54] Module Review libs.osgi (followup)
URL: https://github.com/apache/incubator-netbeans/pull/181#discussion_r147527324
 
 

 ##########
 File path: libs.osgi/build.xml
 ##########
 @@ -22,4 +22,29 @@
 <project basedir="." default="netbeans" name="libs.osgi">
     <description>Builds, tests, and runs the project org.netbeans.libs.osgi</description>
     <import file="../nbbuild/templates/projectized.xml"/>
+    
+    <!-- A task to check if the binary 'external/resolver-1.2.jar exists -->
+    <target name="-check-requires-patching-maven-sources">
+        <available file="external/osgi.cmpn-4.2.jar" property="sources-already-patched" />
+    </target>
+    
+    <!-- 
+         '-javac-init' task is invoked after maven sources have been downloaded 
+         to 'external/org.osgi.compendium-4.2.0.jar'
+         (see external/binaries-list).
+         Netbeans had its own copy of osgi.cmpn-4.2.jar, which is identical to
+         the downloaded binary. The downloaded binary contains the source code
+         in addition to the compiled class files.
+         The sources are now stripped from the binary to create the original file
+         netbeans used to bundle.
+    -->
+    <target name="-prepare-patched-binary" depends="-check-requires-patching-maven-sources" unless="sources-already-patched">
+        <echo message="Patching org.osgi.compendium-4.2.0 for Netbeans..." />
+        <zip destfile="external/osgi.cmpn-4.2.jar">
+            <zipfileset src="external/org.osgi.compendium-4.2.0.jar" excludes="OSGI-OPT/**" />
+        </zip>
+    </target>
+    
+    <!-- Hook into harness "basic-init" task -->
 
 Review comment:
   Another idea: This should read "Hook into harness "javac-init" task"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services