Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9F5C8200D32 for ; Sun, 22 Oct 2017 01:19:55 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9DF5A160BEE; Sat, 21 Oct 2017 23:19:55 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DA381160BD5 for ; Sun, 22 Oct 2017 01:19:54 +0200 (CEST) Received: (qmail 32683 invoked by uid 500); 21 Oct 2017 23:19:54 -0000 Mailing-List: contact dev-help@netbeans.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@netbeans.incubator.apache.org Delivered-To: mailing list dev@netbeans.incubator.apache.org Received: (qmail 32672 invoked by uid 99); 21 Oct 2017 23:19:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 21 Oct 2017 23:19:53 +0000 From: GitBox To: dev@netbeans.apache.org Subject: [GitHub] bondolo commented on issue #173: [NETBEANS-97] Don't add braces around try/synchronized blocks when reformatting Message-ID: <150862799335.6469.13690765807621022788.gitbox@gitbox.apache.org> archived-at: Sat, 21 Oct 2017 23:19:55 -0000 bondolo commented on issue #173: [NETBEANS-97] Don't add braces around try/synchronized blocks when reformatting URL: https://github.com/apache/incubator-netbeans/pull/173#issuecomment-338439126 I agree that not everyone might want this; in part the patch is to allow people to not have extra braces inserted by the formatter where the user did not put them. The opposite side, removing braces is only enabled if the user has adjusted their "Braces Generation" preference to "Eliminate". Eliminate is an option I suspect few people use. This patch is mostly about leaving things the way the user typed them rather than adding unnecessary/unwanted braces. If there was to be an option, which doesn't seem necessary, it would be a "Braces Generation" checkbox "around try & synchronized". ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services