From commits-return-129535-archive-asf-public=cust-asf.ponee.io@mxnet.apache.org Sat Aug 1 08:09:47 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id EFCC218065B for ; Sat, 1 Aug 2020 10:09:46 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 2D14C1251D4 for ; Sat, 1 Aug 2020 08:09:46 +0000 (UTC) Received: (qmail 45021 invoked by uid 500); 1 Aug 2020 08:09:46 -0000 Mailing-List: contact commits-help@mxnet.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.apache.org Delivered-To: mailing list commits@mxnet.apache.org Received: (qmail 45011 invoked by uid 99); 1 Aug 2020 08:09:45 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Aug 2020 08:09:45 +0000 From: =?utf-8?q?GitBox?= To: commits@mxnet.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-mxnet=5D_szha_opened_a_new_pull_request_?= =?utf-8?q?=2318837=3A_=5BNumPy=5D_add_tests_for_sklearn_interoperability?= Message-ID: Date: Sat, 01 Aug 2020 08:09:45 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit szha opened a new pull request #18837: URL: https://github.com/apache/incubator-mxnet/pull/18837 ## Description ## add tests for sklearn interoperability ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [x] Changes are complete (i.e. I finished coding on this PR) - [x] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - [x] Code is well-documented: - For user-facing API changes, API doc string has been updated. - [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - [x] add tests for sklearn interoperability, for discriminant analysis - [x] add implict numpy array creation - [x] testing: skip cv tests when opencv is off - [x] fix ufunc mixed type - [x] add writable option to from_numpy ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org