From commits-return-129610-archive-asf-public=cust-asf.ponee.io@mxnet.apache.org Mon Aug 3 06:28:13 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 4F84A180642 for ; Mon, 3 Aug 2020 08:28:13 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 0EAA91244A7 for ; Mon, 3 Aug 2020 06:28:10 +0000 (UTC) Received: (qmail 33320 invoked by uid 500); 3 Aug 2020 06:28:09 -0000 Mailing-List: contact commits-help@mxnet.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.apache.org Delivered-To: mailing list commits@mxnet.apache.org Received: (qmail 33311 invoked by uid 99); 3 Aug 2020 06:28:09 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Aug 2020 06:28:09 +0000 From: =?utf-8?q?GitBox?= To: commits@mxnet.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-mxnet=5D_ys2843_commented_on_pull_reques?= =?utf-8?q?t_=2318845=3A_Fixed_python_website_double_scroller_and_improve_UX?= Message-ID: <159643608945.32230.16858600024232026558.asfpy@gitbox.apache.org> Date: Mon, 03 Aug 2020 06:28:09 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: ys2843 commented on pull request #18845: URL: https://github.com/apache/incubator-mxnet/pull/18845#issuecomment-667830263 > @ys2843 thanks for the fix! I verified that the double scroller problem is gone and the page seems to run smoother too. > I tried page-up and page-down but it still doesn't seem to work unless I click on the inner div to adjust the focus first. Is there any way to make page scrolling with keyboard work too? Thanks for reviewing, the keyboard control depends on the focused element. I added a fix to auto focus the content element when the pages finish rendering. Please see the (updated) preview. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org