From commits-return-129591-archive-asf-public=cust-asf.ponee.io@mxnet.apache.org Sun Aug 2 23:01:42 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 51446180644 for ; Mon, 3 Aug 2020 01:01:42 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 83BC712449E for ; Sun, 2 Aug 2020 23:01:41 +0000 (UTC) Received: (qmail 79985 invoked by uid 500); 2 Aug 2020 23:01:41 -0000 Mailing-List: contact commits-help@mxnet.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.apache.org Delivered-To: mailing list commits@mxnet.apache.org Received: (qmail 79976 invoked by uid 99); 2 Aug 2020 23:01:41 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Aug 2020 23:01:41 +0000 From: =?utf-8?q?GitBox?= To: commits@mxnet.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-mxnet=5D_ChaiBapchya_commented_on_a_chan?= =?utf-8?q?ge_in_pull_request_=2318797=3A_=5Bv1=2Ex=5D_Mkldnn_header_fix_v1x?= =?utf-8?q?_for_nightly_binaries?= Message-ID: <159640930101.32230.11387576251542567612.asfpy@gitbox.apache.org> Date: Sun, 02 Aug 2020 23:01:41 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: ChaiBapchya commented on a change in pull request #18797: URL: https://github.com/apache/incubator-mxnet/pull/18797#discussion_r464133714 ########## File path: tools/pip/setup.py ########## @@ -156,10 +156,9 @@ def skip_markdown_comments(md): package_data = {'mxnet': [os.path.join('mxnet', os.path.basename(LIB_PATH[0]))], 'dmlc_tracker': []} -if variant.endswith('MKL'): - if platform.system() == 'Darwin': - shutil.copytree(os.path.join(CURRENT_DIR, 'mxnet-build/3rdparty/mkldnn/build/install/include'), - os.path.join(CURRENT_DIR, 'mxnet/include/mkldnn')) +if variant != 'NATIVE': + shutil.copytree(os.path.join(CURRENT_DIR, 'mxnet-build/3rdparty/mkldnn/include'), + os.path.join(CURRENT_DIR, 'mxnet/include/mkldnn')) Review comment: you mean something like this: `mxnet.runtime.Features.is_enabled("MKLDNN")` ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org