mxnet-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #18797: [v1.x] Mkldnn header fix v1x for nightly binaries
Date Sun, 02 Aug 2020 23:01:41 GMT

ChaiBapchya commented on a change in pull request #18797:
URL: https://github.com/apache/incubator-mxnet/pull/18797#discussion_r464133714



##########
File path: tools/pip/setup.py
##########
@@ -156,10 +156,9 @@ def skip_markdown_comments(md):
 
 package_data = {'mxnet': [os.path.join('mxnet', os.path.basename(LIB_PATH[0]))],
                 'dmlc_tracker': []}
-if variant.endswith('MKL'):
-    if platform.system() == 'Darwin':
-        shutil.copytree(os.path.join(CURRENT_DIR, 'mxnet-build/3rdparty/mkldnn/build/install/include'),
-                        os.path.join(CURRENT_DIR, 'mxnet/include/mkldnn'))
+if variant != 'NATIVE':
+    shutil.copytree(os.path.join(CURRENT_DIR, 'mxnet-build/3rdparty/mkldnn/include'),
+                    os.path.join(CURRENT_DIR, 'mxnet/include/mkldnn'))

Review comment:
       you mean something like this: `mxnet.runtime.Features.is_enabled("MKLDNN")` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message