From commits-return-73525-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Fri Feb 1 07:28:46 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2B99018076D for ; Fri, 1 Feb 2019 08:28:46 +0100 (CET) Received: (qmail 19536 invoked by uid 500); 1 Feb 2019 07:28:45 -0000 Mailing-List: contact commits-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list commits@mxnet.incubator.apache.org Received: (qmail 19471 invoked by uid 99); 1 Feb 2019 07:28:45 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Feb 2019 07:28:45 +0000 From: GitBox To: commits@mxnet.apache.org Subject: [GitHub] szha commented on a change in pull request #13896: Cudnn dropout Message-ID: <154900612458.17379.16417848245791156963.gitbox@gitbox.apache.org> Date: Fri, 01 Feb 2019 07:28:44 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit szha commented on a change in pull request #13896: Cudnn dropout URL: https://github.com/apache/incubator-mxnet/pull/13896#discussion_r252954441 ########## File path: src/operator/cudnn_rnn-inl.h ########## @@ -699,7 +699,7 @@ class CuDNNRNNOp : public Operator { if (param_.p > 0) { CUDNN_CALL(cudnnDropoutGetStatesSize(s->dnn_handle_, &dropout_byte_)); dropout_size_ = dropout_byte_ / sizeof(DType); - dropout_states_ = Storage::Get()->Alloc(dropout_byte_, Context::GPU()); + dropout_states_ = Storage::Get()->Alloc(dropout_byte_, Context::GPU(s->dev_id)); Review comment: to test for the correct usage of GPU I'd need more than 1 GPU on the CI ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services