From commits-return-73523-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Fri Feb 1 07:21:32 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D58F41807A6 for ; Fri, 1 Feb 2019 08:21:30 +0100 (CET) Received: (qmail 12928 invoked by uid 500); 1 Feb 2019 07:21:29 -0000 Mailing-List: contact commits-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list commits@mxnet.incubator.apache.org Received: (qmail 12796 invoked by uid 99); 1 Feb 2019 07:21:29 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Feb 2019 07:21:29 +0000 From: GitBox To: commits@mxnet.apache.org Subject: [GitHub] eric-haibin-lin commented on a change in pull request #13896: Cudnn dropout Message-ID: <154900568900.5447.6471288857921646312.gitbox@gitbox.apache.org> Date: Fri, 01 Feb 2019 07:21:29 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit eric-haibin-lin commented on a change in pull request #13896: Cudnn dropout URL: https://github.com/apache/incubator-mxnet/pull/13896#discussion_r252951835 ########## File path: src/operator/cudnn_rnn-inl.h ########## @@ -699,7 +699,7 @@ class CuDNNRNNOp : public Operator { if (param_.p > 0) { CUDNN_CALL(cudnnDropoutGetStatesSize(s->dnn_handle_, &dropout_byte_)); dropout_size_ = dropout_byte_ / sizeof(DType); - dropout_states_ = Storage::Get()->Alloc(dropout_byte_, Context::GPU()); + dropout_states_ = Storage::Get()->Alloc(dropout_byte_, Context::GPU(s->dev_id)); Review comment: Do we have unit test for this? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services