From commits-return-22315-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Fri Feb 2 02:04:00 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 182CD180652 for ; Fri, 2 Feb 2018 02:04:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0746F160C56; Fri, 2 Feb 2018 01:04:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4597F160C44 for ; Fri, 2 Feb 2018 02:03:59 +0100 (CET) Received: (qmail 4101 invoked by uid 500); 2 Feb 2018 01:03:58 -0000 Mailing-List: contact commits-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list commits@mxnet.incubator.apache.org Received: (qmail 4092 invoked by uid 99); 2 Feb 2018 01:03:58 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Feb 2018 01:03:58 +0000 From: GitBox To: commits@mxnet.apache.org Subject: [GitHub] cjolivier01 commented on a change in pull request #9672: CMake CUDA fixes + NCCL Message-ID: <151753343792.26347.17262686719672159567.gitbox@gitbox.apache.org> cjolivier01 commented on a change in pull request #9672: CMake CUDA fixes + NCCL URL: https://github.com/apache/incubator-mxnet/pull/9672#discussion_r165534511 ########## File path: CMakeLists.txt ########## @@ -168,12 +167,43 @@ endif() include_directories(${CMAKE_CURRENT_SOURCE_DIR}/include) include_directories(${CMAKE_CURRENT_SOURCE_DIR}/src) -if(FIRST_CUDA) +if(USE_CUDA) + find_package(CUDA REQUIRED) + add_definitions(-DMSHADOW_USE_CUDA=1) + if(FIRST_CUDA AND (NOT USE_OLDCMAKECUDA)) + if(CUDA_TOOLSET STREQUAL "") + set(CUDA_TOOLSET "${CUDA_VERSION_STRING}") Review comment: yeah, in FindCUDA.cmake -- find_package(CUDA) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services