From dev-return-6273-archive-asf-public=cust-asf.ponee.io@madlib.apache.org Mon Nov 30 22:12:52 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id E43D9180637 for ; Mon, 30 Nov 2020 23:12:52 +0100 (CET) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 53CB566768 for ; Mon, 30 Nov 2020 22:12:52 +0000 (UTC) Received: (qmail 70113 invoked by uid 500); 30 Nov 2020 22:12:51 -0000 Mailing-List: contact dev-help@madlib.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@madlib.apache.org Delivered-To: mailing list dev@madlib.apache.org Received: (qmail 70093 invoked by uid 99); 30 Nov 2020 22:12:51 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Nov 2020 22:12:51 +0000 From: =?utf-8?q?GitBox?= To: dev@madlib.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bmadlib=5D_khannaekta_commented_on_a_change_in_pull?= =?utf-8?q?_request_=23522=3A_DL=3A_Remove_keras_dependency?= Message-ID: <160677437149.15632.5989431670353856154.asfpy@gitbox.apache.org> Date: Mon, 30 Nov 2020 22:12:51 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: khannaekta commented on a change in pull request #522: URL: https://github.com/apache/madlib/pull/522#discussion_r532937425 ########## File path: src/ports/postgres/modules/deep_learning/test/unit_tests/test_madlib_keras.py_in ########## @@ -569,6 +466,198 @@ class MadlibKerasFitTestCase(unittest.TestCase): def test_fit_transition_last_buffer_pass_gpdb(self): self._test_fit_transition_last_buffer_pass(False) + ############### GRAPH AND SESSION TESTS ################################ + def test_fit_eval_2_iterations_mcf_null_gpdb(self): + kwargs = {'GD': {}} + GD = kwargs['GD'] + + ######################### fit for 2 iterations ########## + # iteration 1 + first_iter_keras_sess = self._run_fit_iteration(**kwargs) + self._assert_keras_session_same_as_gd_session(GD) + + first_iter_tf_graph = self.subject.tf.get_default_graph() + + # iteration 2 (last iteration) + last_iter_keras_sess = self._run_fit_iteration(**kwargs) + self._assert_keras_session_same_as_gd_session(GD) + + last_iter_tf_graph = self.subject.tf.get_default_graph() + + self.assertEquals(first_iter_keras_sess, last_iter_keras_sess) + self.assertEquals(first_iter_tf_graph, last_iter_tf_graph) + + ###################### eval transition for last iteration ########### + self._run_eval_iteration(True, last_iter_keras_sess, last_iter_tf_graph, **kwargs) + eval_last_iter_keras_sess = self.subject.K.get_session() + eval_last_iter_tf_graph = self.subject.tf.get_default_graph() + + self.assertNotEquals(eval_last_iter_keras_sess, last_iter_keras_sess) + self.assertNotEquals(eval_last_iter_tf_graph, last_iter_tf_graph) Review comment: That is correct, will add a comment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org