From dev-return-6237-archive-asf-public=cust-asf.ponee.io@madlib.apache.org Wed Oct 14 02:03:46 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id B6FBC18060E for ; Wed, 14 Oct 2020 04:03:46 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id E2C17123469 for ; Wed, 14 Oct 2020 02:03:45 +0000 (UTC) Received: (qmail 65409 invoked by uid 500); 14 Oct 2020 02:03:45 -0000 Mailing-List: contact dev-help@madlib.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@madlib.apache.org Delivered-To: mailing list dev@madlib.apache.org Received: (qmail 65397 invoked by uid 99); 14 Oct 2020 02:03:45 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Oct 2020 02:03:45 +0000 From: =?utf-8?q?GitBox?= To: dev@madlib.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bmadlib=5D_reductionista_commented_on_a_change_in_p?= =?utf-8?q?ull_request_=23520=3A_DL=3A_Restrict_access_to_the_custom_functio?= =?utf-8?q?ns_table?= Message-ID: <160264102534.32230.12166094797421840864.asfpy@gitbox.apache.org> Date: Wed, 14 Oct 2020 02:03:45 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: reductionista commented on a change in pull request #520: URL: https://github.com/apache/madlib/pull/520#discussion_r504356446 ########## File path: src/ports/postgres/modules/deep_learning/madlib_keras_custom_function.py_in ########## @@ -68,6 +72,8 @@ def load_custom_function(schema_madlib, object_table, object, name, description= _validate_object(object) _assert(name is not None, "{0}: function name cannot be NULL!".format(module_name)) + _assert(is_superuser(current_user()), "DL: The user has to have admin "\ + "privilages to load a custom function") Review comment: This is great! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org