From dev-return-6215-archive-asf-public=cust-asf.ponee.io@madlib.apache.org Fri Oct 9 14:07:10 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 1A933180670 for ; Fri, 9 Oct 2020 16:07:10 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 5B3B442414 for ; Fri, 9 Oct 2020 14:07:09 +0000 (UTC) Received: (qmail 74852 invoked by uid 500); 9 Oct 2020 14:07:09 -0000 Mailing-List: contact dev-help@madlib.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@madlib.apache.org Delivered-To: mailing list dev@madlib.apache.org Received: (qmail 74833 invoked by uid 99); 9 Oct 2020 14:07:09 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Oct 2020 14:07:09 +0000 From: =?utf-8?q?GitBox?= To: dev@madlib.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bmadlib=5D_khannaekta_edited_a_comment_on_pull_requ?= =?utf-8?q?est_=23519=3A_DL=3A_Add_a_helper_function_to_load_custom_top_n_ac?= =?utf-8?q?curacy_functions?= Message-ID: <160225242902.32230.8904665027413431977.asfpy@gitbox.apache.org> Date: Fri, 09 Oct 2020 14:07:09 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: khannaekta edited a comment on pull request #519: URL: https://github.com/apache/madlib/pull/519#issuecomment-705885794 > (0) can we please rename this to : > > ``` > load_top_k_accuracy_function( > object table, > k > ) > ```...... Sure, will make those changes > (2) multi-model, top k custom function > > ``` > INFO: Keras Custom Function: Created new custom function table custom_function_table. > CONTEXT: PL/Python function "load_custom_function" > SQL statement " > SELECT madlib.load_custom_function('custom_function_table', > madlib.top_k_categorical_acc_pickled(3, 'top_3_accuracy'), > 'top_3_accuracy', > 'returns top_3_accuracy'); > " > ...... > results OK but please remove verbose output Agreed! I had the same comment in my initial review too. These verbose INFOs are coming from calling `load_custom_function()`, so we should probably suppress those. > (4) did you test with madlib.madlib_keras_fit() ? I tested it manually. But will add an end-to-end test for testing it with fit, fit_multiple and evaluate ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org