madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [madlib] reductionista commented on a change in pull request #522: DL: Remove keras dependency
Date Wed, 21 Oct 2020 19:35:48 GMT

reductionista commented on a change in pull request #522:
URL: https://github.com/apache/madlib/pull/522#discussion_r509614250



##########
File path: src/ports/postgres/modules/deep_learning/test/unit_tests/test_madlib_keras.py_in
##########
@@ -28,12 +28,13 @@ from os import path
 sys.path.append(path.dirname(path.dirname(path.dirname(path.dirname(path.abspath(__file__))))))
 sys.path.append(path.dirname(path.dirname(path.dirname(path.abspath(__file__)))))
 
-import keras
-from keras.models import *
-from keras.layers import *
 import unittest
 from mock import *
 import plpy_mock as plpy
+
+from tensorflow import keras
+from tensorflow.keras.models import *
+from tensorflow.keras.layers import *

Review comment:
       Wow, good catch!!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message