madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [madlib] orhankislal commented on a change in pull request #522: DL: Remove keras dependency
Date Tue, 20 Oct 2020 08:18:11 GMT

orhankislal commented on a change in pull request #522:
URL: https://github.com/apache/madlib/pull/522#discussion_r508300726



##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras_wrapper.py_in
##########
@@ -248,7 +249,7 @@ def parse_optimizer(compile_dict):
     opt_split = compile_dict['optimizer'].split('(')
     opt_name = opt_split[0]
     optimizers = get_optimizers()
-    _assert(opt_name in optimizers,
+    _assert(opt_name.lower() in [o.lower() for o in optimizers.keys()],

Review comment:
       `optimizer` is a mandatory parameter in our `compile_params`. The `opt_name` has to
have some value, it cannot be `None`
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message