madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [madlib] khannaekta edited a comment on pull request #519: DL: Add a helper function to load custom top n accuracy functions
Date Fri, 09 Oct 2020 14:07:09 GMT

khannaekta edited a comment on pull request #519:
URL: https://github.com/apache/madlib/pull/519#issuecomment-705885794


   > (0) can we please rename this to :
   > 
   > ```
   > load_top_k_accuracy_function(
   >     object table,
   >     k
   >     )
   > ```......
   Sure, will make those changes 
    
   > (2) multi-model, top k custom function
   > 
   > ```
   > INFO:  Keras Custom Function: Created new custom function table custom_function_table.
   > CONTEXT:  PL/Python function "load_custom_function"
   > SQL statement "
   >         SELECT  madlib.load_custom_function('custom_function_table',
   >                 madlib.top_k_categorical_acc_pickled(3, 'top_3_accuracy'),
   >                 'top_3_accuracy',
   >                 'returns top_3_accuracy');
   >         "
   >   ......
   > results OK but please remove verbose output
   
   Agreed! I had the same comment in my initial review too. These verbose INFOs are coming
from calling `load_custom_function()`, so we should probably suppress those. 
   
   > (4) did you test with madlib.madlib_keras_fit() ?
   
   I tested it manually. But will add an end-to-end test for testing it with fit, fit_multiple
and evaluate


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message