From dev-return-5656-archive-asf-public=cust-asf.ponee.io@madlib.apache.org Tue Nov 19 22:41:23 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id D13DE180638 for ; Tue, 19 Nov 2019 23:41:22 +0100 (CET) Received: (qmail 45767 invoked by uid 500); 19 Nov 2019 22:41:22 -0000 Mailing-List: contact dev-help@madlib.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@madlib.apache.org Delivered-To: mailing list dev@madlib.apache.org Received: (qmail 45755 invoked by uid 99); 19 Nov 2019 22:41:22 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Nov 2019 22:41:22 +0000 From: GitBox To: dev@madlib.apache.org Subject: [GitHub] [madlib] reductionista commented on a change in pull request #459: DL: Add support for asymmetric segment distribution to preprocessor Message-ID: <157420328206.12299.13303906270078704556.gitbox@gitbox.apache.org> Date: Tue, 19 Nov 2019 22:41:22 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit reductionista commented on a change in pull request #459: DL: Add support for asymmetric segment distribution to preprocessor URL: https://github.com/apache/madlib/pull/459#discussion_r348208110 ########## File path: src/ports/postgres/modules/deep_learning/input_data_preprocessor.py_in ########## @@ -204,42 +207,90 @@ class InputDataPreprocessorDL(object): dep_shape = self._get_dependent_var_shape() dep_shape = ','.join([str(i) for i in dep_shape]) - # Create the mini-batched output table if is_platform_pg(): distributed_by_clause = '' dist_key_clause = '' join_clause = '' select_clause = 'b.*' Review comment: I guess this was already in the code, but just happened to notice that this `select clause` isn't used anywhere. I think we can just remove it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services