From dev-return-5652-archive-asf-public=cust-asf.ponee.io@madlib.apache.org Tue Nov 19 02:06:54 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5DAA4180657 for ; Tue, 19 Nov 2019 03:06:54 +0100 (CET) Received: (qmail 77471 invoked by uid 500); 19 Nov 2019 02:06:53 -0000 Mailing-List: contact dev-help@madlib.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@madlib.apache.org Delivered-To: mailing list dev@madlib.apache.org Received: (qmail 77459 invoked by uid 99); 19 Nov 2019 02:06:53 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Nov 2019 02:06:53 +0000 From: GitBox To: dev@madlib.apache.org Subject: [GitHub] [madlib] reductionista commented on a change in pull request #459: DL: Add support for asymmetric segment distribution to preprocessor Message-ID: <157412921357.3413.5687935372000292850.gitbox@gitbox.apache.org> Date: Tue, 19 Nov 2019 02:06:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit reductionista commented on a change in pull request #459: DL: Add support for asymmetric segment distribution to preprocessor URL: https://github.com/apache/madlib/pull/459#discussion_r347700410 ########## File path: src/ports/postgres/modules/deep_learning/input_data_preprocessor.sql_in ########## @@ -707,7 +707,8 @@ CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.validation_preprocessor_dl( dependent_varname VARCHAR, independent_varname VARCHAR, training_preprocessor_table VARCHAR, - buffer_size INTEGER + buffer_size INTEGER, + distribution_rules TEXT ) RETURNS VOID AS $$ PythonFunctionBodyOnly(deep_learning, input_data_preprocessor) from utilities.control import MinWarning Review comment: Other than that, LGTM ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services