From dev-return-5590-archive-asf-public=cust-asf.ponee.io@madlib.apache.org Tue Nov 5 20:15:43 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4D709180648 for ; Tue, 5 Nov 2019 21:15:43 +0100 (CET) Received: (qmail 42527 invoked by uid 500); 5 Nov 2019 20:15:42 -0000 Mailing-List: contact dev-help@madlib.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@madlib.apache.org Delivered-To: mailing list dev@madlib.apache.org Received: (qmail 42473 invoked by uid 99); 5 Nov 2019 20:15:42 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Nov 2019 20:15:42 +0000 From: GitBox To: dev@madlib.apache.org Subject: [GitHub] [madlib] kaknikhil commented on a change in pull request #432: MADLIB-1351 : Added stopping criteria on perplexity to LDA Message-ID: <157298494234.16216.12383736322225364936.gitbox@gitbox.apache.org> Date: Tue, 05 Nov 2019 20:15:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit kaknikhil commented on a change in pull request #432: MADLIB-1351 : Added stopping criteria on perplexity to LDA URL: https://github.com/apache/madlib/pull/432#discussion_r342750857 ########## File path: src/ports/postgres/modules/lda/lda.py_in ########## @@ -208,15 +232,19 @@ class LDATrainer: doc_topic[{topic_num} + 1:array_upper(doc_topic, 1)], {voc_size}, {topic_num} - ) AS model + ) AS model, Review comment: 1. Adding a comma after `model` makes the query syntactically wrong since n_iterations already has a comma at the end. ~~2. Adding a comma after `perplexity_iterations` will also make the syntax invalid since there will be a comma right before the FROM clause~~ Ignore this comment, i misread the code ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services