From dev-return-5569-archive-asf-public=cust-asf.ponee.io@madlib.apache.org Fri Nov 1 17:43:57 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 36C0C180626 for ; Fri, 1 Nov 2019 18:43:57 +0100 (CET) Received: (qmail 51016 invoked by uid 500); 1 Nov 2019 17:43:56 -0000 Mailing-List: contact dev-help@madlib.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@madlib.apache.org Delivered-To: mailing list dev@madlib.apache.org Received: (qmail 51004 invoked by uid 99); 1 Nov 2019 17:43:56 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Nov 2019 17:43:56 +0000 From: GitBox To: dev@madlib.apache.org Subject: [GitHub] [madlib] khannaekta commented on a change in pull request #454: DL: Fix miscellaneous bugs Message-ID: <157263023641.20828.290372576713665811.gitbox@gitbox.apache.org> Date: Fri, 01 Nov 2019 17:43:56 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit khannaekta commented on a change in pull request #454: DL: Fix miscellaneous bugs URL: https://github.com/apache/madlib/pull/454#discussion_r341680033 ########## File path: src/ports/postgres/modules/deep_learning/madlib_keras_fit_multiple_model.py_in ########## @@ -403,6 +403,17 @@ class FitMultipleModel(): self.update_info_table(mst, False) def run_training(self): + # NOTE: In the DL module, we want to avoid CREATING TEMP tables Review comment: Thanks for noticing. I will move the comment anyways to keep the commit self contained. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services