madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [madlib] hpandeycodeit commented on a change in pull request #432: MADLIB-1351 : Added stopping criteria on perplexity to LDA
Date Tue, 12 Nov 2019 23:16:08 GMT
hpandeycodeit commented on a change in pull request #432: MADLIB-1351 : Added stopping criteria
on perplexity to LDA
URL: https://github.com/apache/madlib/pull/432#discussion_r345496776
 
 

 ##########
 File path: src/ports/postgres/modules/lda/test/lda.sql_in
 ##########
 @@ -474,3 +474,89 @@ select assert(array_upper(perplexity_iters,1)  = 2, 'Perplexity iterations
are d
 select assert(perplexity[1] > 0 , 'Perplexity value should be greate than 0') from lda_model
;
 select assert(array_upper(ARRAY(Select distinct unnest(perplexity)),1)= array_upper(perplexity,1)
, 'Perplexity values should be unique') from lda_model ;
 
+
+-- Test for evaluate_every = 1  and 0 : In this case the iterations should not stop early
--
 
 Review comment:
   when evaluate_every = NULL (it takes the default evaluate_every=0) and in that case, we
don't calculate perplexity. We have a test case for covering evaluate_every = NULL.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message