madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [madlib] hpandeycodeit commented on issue #432: MADLIB-1351 : Added stopping criteria on perplexity to LDA
Date Thu, 07 Nov 2019 18:05:55 GMT
hpandeycodeit commented on issue #432: MADLIB-1351 : Added stopping criteria on perplexity
to LDA
URL: https://github.com/apache/madlib/pull/432#issuecomment-551196322
 
 
   > @hpandeycodeit
   > We should test cases for the following scenarios (not sure if we already have tests
for some of these) :
   > 
   > 1. If evaluate_every <=0, assert that there are no perplexity values.
   > 2. If tolerance == 0, assert that we don't stop early.
   > 3. All permutations of the interface with evaluate_every and tolerance being passed
as NULL and/or not passed at all to make sure we default the values as expected.
   
   Added the test cases for 2 and 3. There was already a test case covering scenario 1. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message