madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [madlib] khannaekta commented on a change in pull request #454: DL: Fix miscellaneous bugs
Date Fri, 01 Nov 2019 17:43:56 GMT
khannaekta commented on a change in pull request #454: DL: Fix miscellaneous bugs
URL: https://github.com/apache/madlib/pull/454#discussion_r341680033
 
 

 ##########
 File path: src/ports/postgres/modules/deep_learning/madlib_keras_fit_multiple_model.py_in
 ##########
 @@ -403,6 +403,17 @@ class FitMultipleModel():
                 self.update_info_table(mst, False)
 
     def run_training(self):
+        # NOTE: In the DL module, we want to avoid CREATING TEMP tables
 
 Review comment:
   Thanks for noticing. I will move the comment anyways to keep the commit self contained.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message