madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [madlib] njayaram2 commented on a change in pull request #365: DL: Add new columns in fit output summary table.
Date Tue, 09 Apr 2019 21:23:24 GMT
njayaram2 commented on a change in pull request #365: DL: Add new columns in fit output summary
table.
URL: https://github.com/apache/madlib/pull/365#discussion_r273710605
 
 

 ##########
 File path: src/ports/postgres/modules/utilities/validate_args.py_in
 ##########
 @@ -365,6 +365,24 @@ def get_cols_and_types(tbl):
     return list(zip(col_names, col_types))
 # -------------------------------------------------------------------------
 
+def get_col_value_and_type(table_name, column_name):
 
 Review comment:
   That's a good suggestion, but it may not be necessary at the moment. If we see this function
getting used more often in the future, let's refactor it out and update it this way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message