madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [madlib] njayaram2 commented on a change in pull request #364: WCC: Performance Improvement
Date Tue, 09 Apr 2019 19:07:45 GMT
njayaram2 commented on a change in pull request #364: WCC: Performance Improvement
URL: https://github.com/apache/madlib/pull/364#discussion_r273656393
 
 

 ##########
 File path: src/ports/postgres/modules/graph/wcc.py_in
 ##########
 @@ -117,12 +118,21 @@ def wcc(schema_madlib, vertex_table, vertex_id, edge_table, edge_args,
     old_new_update_where_condition = ''
     new_to_update_where_condition = ''
     edge_to_update_where_condition = ''
+    edge_inverse_to_update_where_condition = ''
 
     INT_MAX = 2147483647
     component_id = 'component_id'
     grouping_cols_comma = '' if not grouping_cols else grouping_cols + ','
     comma_grouping_cols = '' if not grouping_cols else ',' + grouping_cols
 
+    if not is_platform_pg():
+        plpy.execute("DROP TABLE IF EXISTS {edge_inverse}".format(**locals()))
 
 Review comment:
   We shouldn't drop a table we did not create. This drop should be at the end of the function
instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message