madlib-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [madlib] kaknikhil commented on a change in pull request #361: Minibatch Preprocessor DL: Add optional num_classes param.
Date Mon, 01 Apr 2019 21:20:48 GMT
kaknikhil commented on a change in pull request #361: Minibatch Preprocessor DL: Add optional
num_classes param.
URL: https://github.com/apache/madlib/pull/361#discussion_r271008185
 
 

 ##########
 File path: src/ports/postgres/modules/internal/db_utils.py_in
 ##########
 @@ -39,10 +40,13 @@ def get_distinct_col_levels(source_table, col_name, col_type=None):
     else:
         dep_var_text_patched = col_name
 
+    where_clause = 'WHERE ({0}) is NOT NULL'.format(col_name)
+    if not exclude_nulls:
 
 Review comment:
   Renaming this variable to `include_nulls` will make it easier to read

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message